<html><head></head><body><div style="font-family: Verdana;font-size: 12.0px;"><div>
<div>Alan,</div>
<div> </div>
<div>Thanks, I don't see anything that would need to be re-ordered, but point taken on the passwords. I will look to address that. </div>
<div>
<div name="quote" style="margin:10px 5px 5px 10px; padding: 10px 0 10px 10px; border-left:2px solid #C3D9E5; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div style="margin:0 0 10px 0;"><b>Sent:</b> Thursday, October 22, 2015 at 3:02 AM<br/>
<b>From:</b> "Alan McKinnon" <alan.mckinnon@gmail.com><br/>
<b>To:</b> rancid-discuss@shrubbery.net<br/>
<b>Subject:</b> Re: [rancid] Pointers for RANCID Script</div>
<div name="quoted-content">On 22/10/2015 03:39, Ken Celenza wrote:<br/>
> I put together Rancid for Riverbed based on rblogin from<br/>
> <a href="http://article.gmane.org/gmane.network.rancid/2697/match=riverbed" target="_blank">http://article.gmane.org/gmane.network.rancid/2697/match=riverbed</a> by<br/>
> Bill Jacqmein and panrancid script.<br/>
><br/>
> I was hoping I could get some feedback on what mistakes I have made. I<br/>
> posted the code here:<br/>
> <a href="https://github.com/itdependsnetworks/Rancid-Riverbed" target="_blank">https://github.com/itdependsnetworks/Rancid-Riverbed</a><br/>
<br/>
<br/>
<br/>
It looks very much like a stripped down version of the original Cisco<br/>
parser - I recognise the pattern :-)<br/>
<br/>
I'm not familiar with that hardware at all, so can't comment on the data<br/>
fetched and what your script does with it, or if rblogin is suitable. So<br/>
I looked it over generally and have only two comments:<br/>
<br/>
<br/>
On line 36, this:<br/>
print "rancid 3.1\n";<br/>
probably wants changing to the actual script name and current version.<br/>
<br/>
<br/>
sub ShowConfig pumps all data straight into ProcessHistory() unchanged.<br/>
It doesn't do any re-ordering of lists, or redact sensitive information<br/>
(with $filter_pwds) at all. I would be very happy to see a kit vendor<br/>
get their act together and provide sane output to "show configuration",<br/>
but somehow I doubt it. Are you certain this kit gives output that never<br/>
requires tweaking, and never contains any sensitive information at all?<br/>
<br/>
<br/>
--<br/>
Alan McKinnon<br/>
alan.mckinnon@gmail.com<br/>
<br/>
_______________________________________________<br/>
Rancid-discuss mailing list<br/>
Rancid-discuss@shrubbery.net<br/>
<a href="http://www.shrubbery.net/mailman/listinfo/rancid-discuss" target="_blank">http://www.shrubbery.net/mailman/listinfo/rancid-discuss</a></div>
</div>
</div>
</div></div></body></html>