bug report---- missed cmd(s): show install active

[john heasley]

Wed, Oct 29, 2003 at 06:10:03PM -0800, Forier Zhang:
> the rancid running perfect with my Cisco GSR routers, but when I 
> upgraded the IOS to some latest version like 12.0(26.3)S, the do-diffs 
> or 'rancid router-name' stopped with error message says:
> 
> 10.21.28.4: missed cmd(s): show install active
> 
> after some debug I found that the problem maybe came with the 'show 
> version' output format in the new IOS versions, most likely it's the 
> lines as below:
> 
> WARNING: Old fab-loader in slot 0; use "upgrade fabric-downloader" to update
> WARNING: Old MBus agent ROM in some slots; use "upgrade mbus-agent-rom" 
> to update
> 
> looks the current version (2.2.2) can not handle the ';' correctly.
> of course, the problem gone after I did the upgrading as indicated in 
> the above warning messages. (they gone from the 'show version')
> 
> does anyone there see this issue ?
> 
> thanks !

This is more than likely trigger not by the ';' or anything else in
those messages, but by how 2.2.2 parsed them, where by we tried to
also collect the "suggested fix" that followed these warning.  At
some point in the recent past, Cisco (that's you :) dropped the
suggestion text.

If the last warning in the list had been one for which rancid tried
to collect the "suggested fix", then it could have inadvertantly
eaten the next command-line, which in 2.2.2 would be 'show install
active', and resulted in it believing that the command had not be
run properly.

Hence, we have the following poised for 2.3:

----------------------------
revision 1.143
date: 2003/09/10 19:33:58;  author: heas;  state: Exp;  lines: +0 -8
drop the "suggested action" portion of GSR LC/RP ROM upgrade warnings.  Cisco
keeps changing the format.
----------------------------

warning, I do not know if this will cleanly apply to 2.2.2.  It might
have to be wedged in manually.

Index: rancid.in
===================================================================
RCS file: /home/rancid/.CVS/rancid/bin/rancid.in,v
retrieving revision 1.142
retrieving revision 1.143
diff -u -r1.142 -r1.143
--- rancid.in	23 Aug 2003 19:10:32 -0000	1.142
+++ rancid.in	10 Sep 2003 19:33:58 -0000	1.143
@@ -296,14 +296,6 @@
 		ProcessHistory("COMMENTS","keysort","I0","!\n");
 	    }
 	    ProcessHistory("COMMENTS","keysort","I1","! $_");
-	    if (/Recommend RP/i) {
-		# RP Slot Warning is only single line
-		$_ = "\n";
-	    } else {
-		# The line after the WARNING is what to do about it.
-		$_ = <INPUT>; tr/\015//d;
-	    }
-	    ProcessHistory("COMMENTS","keysort","I1","!          $_");
 	}
 	if (/^Configuration register is (.*)$/) {
 	    $config_register=$1;