[rancid] Several suggestions about rancid-3.2.p7

[heasley]

Fri, Jun 05, 2015 at 08:45:38PM +0900, Tetsuo Handa:
> heasley wrote:
> > > (3) I noticed that bin/control_rancid.in forgot to exclude .cvsignore
> > >     file in the
> > > 
> > >       # delete configs from RCS for routers not listed in routers.up.
> > 
> > 	...
> > 
> > I update 3.2p6 a few days ago for this.  thanks
> 
> I expect that you do not tamper released files, or there will be confusion
> between those who downloaded old version of file and those who downloaded
> new version of file.

sorry, thought i'd fixed the omission before anyone fetched it.

> > 
> > > (4) Usually, PATH environment variable should not contain "."
> > >     (current directory).
> > 
> > I presume that it inheritted this from your environment or whomever ran
> > configure.
> > 
> 
> Unfortunately, the "." comes from the configure script when "dirname no" is
> executed due to nonexistent program. I think you can remove "." at the later
> 
>   ENV_PATH=`echo $ENV_PATH | $PERLV_PATH -e ...
> 
> line of the configure script.

i dont see it, but ok, i'll remove it in the path compression

> ----------
>   test -z "$ac_cv_path_CVS" && ac_cv_path_CVS="no"
>   ;;
> esac
> fi
> CVS=$ac_cv_path_CVS
> if test -n "$CVS"; then
>   { $as_echo "$as_me:${as_lineno-$LINENO}: result: $CVS" >&5
> $as_echo "$CVS" >&6; }
> else
>   { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
> $as_echo "no" >&6; }
> fi
> 
> 
>     ENV_PATH="$ENV_PATH:`dirname $ac_cv_path_CVS`"
> ----------
> 
> ----------
> + test -z ''
> + ac_cv_path_CVS=no
> + CVS=no
> + test -n no
> + printf '%s\n' 'configure:5475: result: no'
> + printf '%s\n' no
> no
> ++ dirname no
> + ENV_PATH=/usr/bin:/usr/bin:/usr/sbin:/usr/bin:/usr/bin:.
> ----------