[rancid] Pointers for RANCID Script

[Alan McKinnon]

On 22/10/2015 03:39, Ken Celenza wrote:
> I put together Rancid for Riverbed based on rblogin from
> http://article.gmane.org/gmane.network.rancid/2697/match=riverbed by
> Bill Jacqmein and panrancid script.
>  
> I was hoping I could get some feedback on what mistakes I have made. I
> posted the code here:
> https://github.com/itdependsnetworks/Rancid-Riverbed



It looks very much like a stripped down version of the original Cisco
parser - I recognise the pattern :-)

I'm not familiar with that hardware at all, so can't comment on the data
fetched and what your script does with it, or if rblogin is suitable. So
I looked it over generally and have only two comments:


On line 36, this:
	print "rancid 3.1\n";
probably wants changing to the actual script name and current version.


sub ShowConfig pumps all data straight into ProcessHistory() unchanged.
It doesn't do any re-ordering of lists, or redact sensitive information
(with $filter_pwds) at all. I would be very happy to see a kit vendor
get their act together and provide sane output to "show configuration",
but somehow I doubt it. Are you certain this kit gives output that never
requires tweaking, and never contains any sensitive information at all?


-- 
Alan McKinnon
alan.mckinnon at gmail.com