[rancid] --with-git

[Gauthier, Chris]

Thu, Jul 06, 2017 at 02:46:46PM +0000, Gauthier, Chris:
    > Heasley,
    > 
    > I know you fixed the –with-git option (broken in 3.6.2) in the current alpha build.  After looking at the CHANGES file, is it safe to copy the alpha’s configure file to 3.6.2 and have the –with-git option work?   Our sysadmins really don’t want to run alpha anything, but we do need the git compatibility.   Or, is running 3.6.1 a better option?
    
    yes, i think that you can just copy configure.  if you can wait a few
    days, that alpha will soon be the next version; i'm trying to wrap-up
    the  2 problems recently reported for ASA and cienna.
    

I will probably use the new version once it is out.  However, I did a diff this morning and added the specific lines that pertain to “git” in the alpha into the 3.6.2 configure.  In the meantime, I am planning on continuing with the 3.6.2 route.  Here is the diff output for everyone’s benefit.

[user at localhost rancid-3.6.2]$ diff -u configure-3.6.2-orig configure
--- configure-3.6.2-orig	2017-07-06 08:31:24.889061430 -0700
+++ configure	2017-07-06 08:37:46.235204141 -0700
@@ -759,6 +759,7 @@
 enable_mk_localstatedir
 enable_conf_install
 with_svn
+with_git
 enable_mail_plus
 enable_adminmail_plus
 '
@@ -1408,6 +1409,7 @@
   --without-PACKAGE       do not use PACKAGE (same as --with-PACKAGE=no)
   --with-svn=fstype       use subversion instead of cvs, with optional svn
                           fstype (fsfs|bdb)
+  --with-git              use git instead of cvs

 Some influential environment variables:
   CC          C compiler command
@@ -4936,7 +4938,27 @@
 else
   { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
 $as_echo "no" >&6; }
-    RCSSYS="cvs"
+
+# Check whether --with-git was given.
+if test "${with_git+set}" = set; then :
+  withval=$with_git;  case "$withval" in
+      yes)
+       { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
+$as_echo "yes" >&6; }
+       RCSSYS="git"
+       ;;
+      no)
+       { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
+$as_echo "no" >&6; }
+       RCSSYS="cvs"
+      esac
+
+else
+  { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
+$as_echo "no" >&6; }
+        RCSSYS="cvs"
+
+fi

 fi


Chris GauthierSenior Network Engineer | comScore, Inc.
o +1 503-331-2704cgauthier at comscore.com
317 SW Alder St, Suite 500 | Portland | OR97204
............................................................................................................................................................................................................................

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.shrubbery.net/pipermail/rancid-discuss/attachments/20170706/969c84b5/attachment.html>