[rancid] paloalto feedback in current alpha [was: Re: clogin commenting script commands following multiple blanks lines]

[heasley]

Fri, Oct 26, 2018 at 06:24:10PM -0400, Erik Muller:
> On 10/24/18 18:32 , heasley wrote:
> > Wed, Oct 24, 2018 at 09:19:31PM +0000, heasley:
> > ok; committed.  Either the alpha tarball or the svn repo.  Welcome testers,
> > esp for palo alto, of which I have none.
> 
> At least on 8.1.4 on my 3250s, the cli is a little bit busted until you get out of interactive mode - for every space you enter between words in the command, it redraws the current line, which was messing up the prompt matching as below.  Fix for that attached at end of message.
> -e

super; committed.  thanks.

> diff -ur rancid-3.99.99/etc/rancid.types.base rancid-3.99.99-em/etc/rancid.types.base
> --- rancid-3.99.99/etc/rancid.types.base	2018-10-24 11:13:49.000000000 -0400
> +++ rancid-3.99.99-em/etc/rancid.types.base	2018-10-26 17:16:53.950868707 -0400
> @@ -607,9 +607,8 @@
>  paloalto;login;panlogin
>  paloalto;module;panos
>  paloalto;inloop;panos::inloop
> -paloalto;command;rancid::RunCommand;set cli scripting-mode on
> -paloalto;command;rancid::RunCommand;set cli pager off
>  paloalto;command;panos::ShowInfo;show system info
> +paloalto;command;panos::ShowInventory;show chassis inventory
>  paloalto;command;panos::ShowConfig;show config running
>  #
>  procket;script;prancid
> diff -ur rancid-3.99.99/lib/panos.pm.in rancid-3.99.99-em/lib/panos.pm.in
> --- rancid-3.99.99/lib/panos.pm.in	2016-02-16 07:28:46.000000000 -0500
> +++ rancid-3.99.99-em/lib/panos.pm.in	2018-10-26 17:19:11.552895792 -0400
> @@ -119,6 +119,23 @@
>      return(0);
>  }
> 
> +# This routine parses "show chassis inventory"
> +sub ShowInventory {
> +    my($INPUT, $OUTPUT, $cmd) = @_;
> +    my($slot);
> +
> +    print STDERR "    In ShowInventory:: $_" if ($debug);
> +
> +    while (<$INPUT>) {
> +	tr/\015//d;
> +	last if (/^$prompt/);
> +
> +	ProcessHistory("INV","","","#$_");
> +    }
> +    ProcessHistory("INV","","","#\n");
> +    return(0);
> +}
> +
> 
>  # This routine parses "show config running"
>  sub ShowConfig {

Is this a new command or specific to larger platforms?  What is the error
if the command is unknown?

> diff -ur rancid-3.99.99/lib/nxos.pm.in rancid-3.99.99-em/lib/nxos.pm.in
> --- rancid-3.99.99/lib/nxos.pm.in	2018-09-19 18:02:44.000000000 -0400
> +++ rancid-3.99.99-em/lib/nxos.pm.in	2018-10-26 17:58:51.611639817 -0400
> @@ -494,9 +494,12 @@
>  	# Drop vtp_debug.log and vtp_debug_old.log CDETS bug CSCuy87611
>  	/\s+vtp_debug(_old)?\.log$/ && next;
> 
> +	# Drop bcm_mem_locl_trace.log
> +	/\s+bcm_mem_lock_trace\.log$/ && next;
> +
>  	next if (/BufferMonitor-1HourData/);
> 
> -	if (/( debug_logs| log)\/$/) {
> +	if (/( debug_logs| log| vdc_\d+)\/$/) {
>  	    # change
>  	    #         8192    Jan 08 14:05:05 2015  log/
>  	    # to

did I miss an explaination of this patch?  I see what it does, but ...