[rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment

[Anderson, Charles R]

My example below WAS from an EX2200.  We have some others that always report -10 (even in toasty closets)--I wonder if that is off-scale low due to a sensor failure?  I have also seen N/A in 2016, but not lately.  What software version are you running?  We are running 12.3R12-S2 on this particular outdoor EX2200.  I can try to find out what version we were running in 2016 when we last saw N/A.  I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.

On Wed, Feb 20, 2019 at 08:54:39AM -0800, Emille Blanc wrote:
> Ironically, we rely on RANCID to tell us when our cabinets get too cold on such devices.
> Mostly because our NMS is hopeless, and can't do it (Enterprise! Closed source!), so it never occurred to me to submit a patch for this.
> 
> However, some devices (namely, EX2200's) don't understand zero, or sub-zero degrees and report it as N/A.
> I've attached a patch to cover this circumstance.
> 
>   # Class Item                           Status
>   # Power FPC 0 Power Supply 0           OK        
>   # Temp  FPC 0 GEPHY1                   OK        
> - #       FPC 0 GEPHY2                   OK         N/A
> + #       FPC 0 GEPHY2                   OK        
>   #       FPC 0 GEPHY3                   OK        
>   #       FPC 0 GEPHY4                   OK        
>   # 
> 
> -----Original Message-----
> From: Rancid-discuss [mailto:rancid-discuss-bounces at shrubbery.net] On Behalf Of Anderson, Charles R
> Sent: Tuesday, February 19, 2019 6:50 AM
> To: rancid-discuss at shrubbery.net
> Subject: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
> 
> One of our switches is in an outdoor cabinet.  It gets below 0 sometimes so we see output like this:
> 
>   # Temp  FPC 0 GEPHY1                   OK
>   #       FPC 0 GEPHY2                   OK
>   #       FPC 0 GEPHY3                   OK
> - #       FPC 0 GEPHY4                   OK         -5 degrees C / 23 degrees F
> + #       FPC 0 GEPHY4                   OK
>   #
> 
> The attached patch fixes ShowChassisEnvironment so it matches the - sign.