[tac_plus] Re: opt_G broken again :(

[Nathan Schrenk]

I have something similar in the patch that I apply locally to
tacacs+-F4.0.4.15, which I've attached to this message.  I am also using
Linux and just as you observed, without the adjustment to the SIGCHLD
handling you end up with a defunct process per connection.

Nathan

On 3/16/09, John Payne <john at sackheads.org> wrote:
>
>
> On Mar 16, 2009, at 9:53 AM, John Payne wrote:
>
> > The opt_G timeline:
> >
> > First patch:
> http://www.shrubbery.net/pipermail/tac_plus/2007-October/000158.html
> > Second patch to fix defunct processes:
> http://www.shrubbery.net/pipermail/tac_plus/2007-October/000163.html
> > Third patch to make it work:
> http://www.shrubbery.net/pipermail/tac_plus/2008-June/000246.html
> >
> > Unfortunately, the third patch has started causing defunct processes
> > again.
>
>
> This seems to resolve the defunct process issue:
>
> *** tac_plus.c.orig     2009-03-16 14:05:29.000000000 -0400
> --- tac_plus.c  2009-03-16 14:05:49.000000000 -0400
> ***************
> *** 447,452 ****
> --- 447,457 ----
>              */
>             open_logfile();
>         }
> + #ifndef REAPCHILD
> +         signal(SIGCHLD, reapchild);
> + #else
> +         signal(SIGCHLD, SIG_IGN);
> + #endif /* REAPCHILD */
>        }
>
>        ostream = NULL;
>
>
> Probably a cleaner way, but... it works for me :)
>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> http://www.shrubbery.net/pipermail/tac_plus/attachments/20090316/7f2a6494/attachment.html
>
> _______________________________________________
> tac_plus mailing list
> tac_plus at shrubbery.net
> http://www.shrubbery.net/mailman/listinfo.cgi/tac_plus
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.shrubbery.net/pipermail/tac_plus/attachments/20090317/eafd9b39/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tacacs+-F4.0.4.15-foreground.patch
Type: application/octet-stream
Size: 2873 bytes
Desc: not available
Url : http://www.shrubbery.net/pipermail/tac_plus/attachments/20090317/eafd9b39/attachment.obj