Problems with the rancid ERX module jerancid

[john heasley]

Got it.  Thanks.

Wed, Sep 22, 2004 at 02:25:57PM +0100, Mark Loveley:
> Hi
> 
> I've just started using rancid and have found an issue with the ERX
> module.
> 
> I'm running version 2.3.1 of rancid and talking to ERX's of different
> software releases 5.0 and 5.2.
> 
> Rancid fails when collecting from both of our ERX's. It seems all
> commands are actually executed but the script doesn't recognise they
> have executed.
> 
> it seems to fail on the dir command as the logic appears to be wrong...
> 
> on line 266 of jerancid the code says:-
>         return(-1) if (/active\/standby/ && !/not sync/);
> I think it should be:-
>         return(-1) if (/active\/standby/ && /not sync/);
> as in continue if the unit is in sync (double negative being used in the
> original).
> 
> Once edited I get a clean run.
> 
> HTH
> -- 
> | Mark Loveley               Broadband Solutions for
> | Network Engineer                 Home & Business @
> | PlusNet plc				www.plus.net
> +------ PlusNet - The smarter way to Internet! -----