[rancid] Re: 2.3.2a5: Do not print empty PID/VID/SN

[Michael Stefaniuc]

john heasley wrote:
> Fri, Aug 18, 2006 at 03:16:26PM +0200, Michael Stefaniuc:
>>the attached patch tries to deal with the saved config file bloat
>>introduced by "show inventory raw" by not printing empty PID/VID/SN
>>lines. The bloat is a problem on big modular switches with a couple of
>>line cards in.
>>
> 
> This looks fine to me, but we can not accept copyrighted patches or modules
> unless you're transfering rights to us or remove the copyright.
IANAL but is this a copyright or license problem? I've sent all the
"2.3.2a5" marked patches to be included into the official rancid
distribution. If all it takes to achieve this is to renounce on my
copyright so be it. I do not mind as the patches are small and the
amount of "innovation" those patches implement is infinitesimal. The
copyright was more to give credit than anything else.

bye
	michael

>>Copyright Michael Stefaniuc <mstefani at redhat.com> for Red Hat
>>
>>Do not print empty PID:, VID: and SN: lines. Most entries from
>>"show inventory raw" have those empty bloating up the saved config.
>>
>>--- ./bin/rancid.in.empty	2006-08-18 11:55:24.000000000 +0200
>>+++ ./bin/rancid.in	2006-08-18 12:03:56.000000000 +0200
>>@@ -1196,9 +1196,13 @@
>> 	    ProcessHistory("INVENTORY","","", sprintf("!%-30s %s\n", $1, $2));
>> 	    next;
>> 	}
>>-	# split PID/VID line
>>-	if (/^(PID: \S*)\s*, (VID: \S*)\s*, (SN: \S*)\s*$/) {
>>-	    ProcessHistory("INVENTORY","","", "!$1\n!$2\n!$3\n");
>>+	# split PID/VID/SN line
>>+	if (/^PID: (\S*)\s*, VID: (\S*)\s*, SN: (\S*)\s*$/) {
>>+	    my $entries = "";
>>+	    $entries .= "!PID: $1\n" if ($1);
>>+	    $entries .= "!VID: $2\n" if ($2);
>>+	    $entries .= "!SN: $3\n" if ($3);
>>+	    ProcessHistory("INVENTORY","","", "$entries");
>> 	    next;
>> 	}
>> 	ProcessHistory("INVENTORY","","","!$_");
> 
> 
>>_______________________________________________
>>Rancid-discuss mailing list
>>Rancid-discuss at shrubbery.net
>>http://www.shrubbery.net/mailman/listinfo.cgi/rancid-discuss


-- 
Michael Stefaniuc               Tel.: +49-711-96437-199
Sr. Network Engineer            Fax.: +49-711-96437-111
Red Hat GmbH                    Email: mstefani at redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart