[rancid] Re: clogin and CSS bug and fix?

[john heasley]

Thu, Jul 23, 2009 at 10:35:00AM +0000, Max Allan:
> 
> Hello,
>  
> I've just started using rancid (2.3.2) and I think I've found a minor clogin bug and fixed it.
>  
> I've got some CSSs that don't require enable, you log straight in to enable mode.
>  
> When the login tries to exit I get an error  :
> can't read "do_saveconfig": no such variable
>     while executing
> "if {$do_saveconfig} {

ftp://ftp.shrubbery.net/pub/rancid/rancid-2.3.2.p1

>                                                     catch {send "y\r"}
>                                                   } else {
>                                                     catch {send "n\r"}
>                                                   }"
> 
>  
> >From my quick reading of clogin and limited understanding of expect/tcl the problem is because the "do_saveconfig" is only made global in "proc do_enable". I'm never going to run do_enable because I don't need it.
>  
> So, to fix it, I added one line to the start of "proc run_commands " :
> global do_saveconfig in_proc
>  
> So, without having a great understanding of tcl/clogin , I don't know if that is that going to break something else? (It fixes the Css problem though)
> Any opinions?
>  
> Regards,
> Max
> _________________________________________________________________
> Windows Live Messenger: Celebrate 10 amazing years with free winks and emoticons.
> http://clk.atdmt.com/UKM/go/157562755/direct/01/
> _______________________________________________
> Rancid-discuss mailing list
> Rancid-discuss at shrubbery.net
> http://www.shrubbery.net/mailman/listinfo.cgi/rancid-discuss